feat: standard schema for validation by florian-lefebvre · Pull Request #543 · bombshell-dev/clack

florian-lefebvre · 2026-05-19T13:30:27Z

What does this PR do?

Allows using Standard Schema compatible libraries for validate(). Discussed on Discord.

Docs PR: bombshell-dev/docs#42

Type of change

Checklist

pnpm test passes (or targeted tests for my change)
pnpm format has been run
I have added/updated tests for my changes (if applicable)
I have added a changeset

AI-generated code disclosure

This PR includes AI-generated code

changeset-bot · 2026-05-19T13:30:36Z

🦋 Changeset detected

Latest commit: 2ca6fa9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clack/prompts	Minor
@clack/core	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2026-05-19T16:26:10Z

@example/basic

@example/changesets

npm i https://pkg.pr.new/@clack/core@543

npm i https://pkg.pr.new/@clack/prompts@543

commit: 2ca6fa9

ghostdevv

the jsdoc comments above the validate options would need updating, as well as the docs https://github.com/bombshell-dev/docs/

natemoo-re

Code looks great, changeset is perfect, just minor feedback on the example!

florian-lefebvre · 2026-05-20T06:46:57Z

I also want to note that the PR does not support schema transforms (they will run but not be used). That would require more changes to represent input and output in types. Out of scope of this PR but if you're interested let me know!

florian-lefebvre · 2026-05-20T06:50:26Z

@ghostdevv docs PR is available at bombshell-dev/docs#42

ghostdevv · 2026-05-20T13:53:45Z

Also, this would be breaking right?

Co-authored-by: James Garbutt <43081j@users.noreply.github.com>

florian-lefebvre · 2026-05-20T14:52:43Z

@43081j yeah I was also hesitating. I inlined it, the spec says it's absolutely fine

florian-lefebvre · 2026-05-20T14:53:17Z

Also, this would be breaking right?

@ghostdevv by "this", are you referring to input/output/transforms or this PR?

ghostdevv · 2026-05-20T14:57:44Z

Also, this would be breaking right?

@ghostdevv by "this", are you referring to input/output/transforms or this PR?

Yea, as this PR changes the behavior of the validate option

florian-lefebvre · 2026-05-20T15:12:05Z

I'm not sure it's fully breaking. No change as a user but it's true that if you are dealing with lower level APIs like in the date prompt, then it requires changes. So maybe it's a major for core and a minor for prompts

ghostdevv · 2026-05-20T16:18:56Z

I'm not sure it's fully breaking. No change as a user but it's true that if you are dealing with lower level APIs like in the date prompt, then it requires changes. So maybe it's a major for core and a minor for prompts

Ah, I'm so sorry but I missed the fact that the old behavior is still available 🤦‍♀️

43081j · 2026-05-21T08:42:36Z

technically, we can strip the standard schema types down to only the parts we use too. but i'm happy either way.

inlining it is better than pulling a dependency still

florian-lefebvre · 2026-05-21T09:29:41Z

I just checked and very little can be stripped, only InferInput and InferOutput. So I'd say it's worth leaving it as is

Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>

ghostdevv

last thing 😄 otherwise lgtm

ghostdevv · 2026-05-23T23:27:40Z

+/**
+ * Represents the `validate()` option. A function or a
+ * [Standard Schema](https://github.com/standard-schema/standard-schema)
+ * that validates user input. If a custom function is given, you should return a
+ * `string` or `Error` to show as a validation error, or `undefined` to accept the result.
+ */


Suggested change

/**

* Represents the `validate()` option. A function or a

* [Standard Schema](https://github.com/standard-schema/standard-schema)

* that validates user input. If a custom function is given, you should return a

* `string` or `Error` to show as a validation error, or `undefined` to accept the result.

*/

/**

* A function or [Standard Schema](https://github.com/standard-schema/standard-schema)

* that validates user input. If a custom function is given, you should return a

* `string` or `Error` to show as a validation error, or `undefined` to accept the result.

*

* @example Using arktype

* ```ts

* import { text } from '@clack/prompts';

* import { type } from 'arktype';

*

* const name = await text({

* message: 'Enter your name (letters only)',

* validate: type('string.alpha').describe('Name can only contain letters'),

* });

* ```

*

* @example Custom validator

* ```ts

* import { text } from '@clack/prompts';

*

* const age = await text({

* message: 'Enter your age:',

* validate(value) {

* if (!value) return 'Please enter a value';

* const num = parseInt(value);

* if (isNaN(num)) return 'Please enter a valid number';

* if (num < 0 || num > 120) return 'Age must be between 0 and 120';

* return undefined;

* },

* });

* ```

*/

feat: standard schema for validation

a4a4f60

florian-lefebvre mentioned this pull request May 19, 2026

feat: standard schema for validation bombshell-dev/docs#42

Open

florian-lefebvre marked this pull request as ready for review May 19, 2026 13:34

fix: types

d071d6d

ghostdevv reviewed May 19, 2026

View reviewed changes

Comment thread examples/basic/standard-schema-validation.ts Outdated

Comment thread packages/core/src/utils/validation.ts

natemoo-re reviewed May 20, 2026

View reviewed changes

Comment thread examples/basic/standard-schema-validation.ts Outdated

Comment thread packages/core/src/utils/validation.ts Outdated

florian-lefebvre added 3 commits May 20, 2026 08:40

feedback

b374153

feedback

491371d

fix: test

5b6579d

update todo

fd18aae

43081j reviewed May 20, 2026

View reviewed changes

Comment thread packages/core/src/utils/validation.ts Outdated

43081j reviewed May 20, 2026

View reviewed changes

Comment thread packages/core/src/utils/validation.ts Outdated

43081j reviewed May 20, 2026

View reviewed changes

Comment thread packages/core/package.json Outdated

florian-lefebvre and others added 3 commits May 20, 2026 16:48

Update packages/core/src/utils/validation.ts

f318c5b

Co-authored-by: James Garbutt <43081j@users.noreply.github.com>

Update packages/core/src/utils/validation.ts

df2f01a

Co-authored-by: James Garbutt <43081j@users.noreply.github.com>

inline standard schema

3f77e8a

43081j approved these changes May 21, 2026

View reviewed changes

ghostdevv reviewed May 21, 2026

View reviewed changes

Comment thread examples/basic/standard-schema-validation.ts Outdated

ghostdevv suggested changes May 21, 2026

View reviewed changes

Comment thread packages/core/src/prompts/prompt.ts Outdated

Comment thread packages/core/src/utils/validation.ts Outdated

florian-lefebvre and others added 3 commits May 22, 2026 09:40

feedback

56f0713

Update packages/core/src/prompts/prompt.ts

0f1fceb

Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>

Update packages/core/src/utils/validation.ts

1a23de5

Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>

florian-lefebvre requested a review from ghostdevv May 22, 2026 07:41

jsdocs

2ca6fa9

ghostdevv suggested changes May 23, 2026

View reviewed changes

-/**
- * Represents the `validate()` option. A function or a
- * [Standard Schema](https://github.com/standard-schema/standard-schema)
- * that validates user input. If a custom function is given, you should return a
- * `string` or `Error` to show as a validation error, or `undefined` to accept the result.
- */
+/**
+ * A function or [Standard Schema](https://github.com/standard-schema/standard-schema)
+ * that validates user input. If a custom function is given, you should return a
+ * `string` or `Error` to show as a validation error, or `undefined` to accept the result.
+ *
+ * @example Using arktype
+ * ```ts
+ * import { text } from '@clack/prompts';
+ * import { type } from 'arktype';
+ *
+ * const name = await text({
+ *   message: 'Enter your name (letters only)',
+ *   validate: type('string.alpha').describe('Name can only contain letters'),
+ * });
+ * ```
+ *
+ * @example Custom validator
+ * ```ts
+ * import { text } from '@clack/prompts';
+ *
+ * const age = await text({
+ *   message: 'Enter your age:',
+ *   validate(value) {
+ *     if (!value) return 'Please enter a value';
+ *     const num = parseInt(value);
+ *     if (isNaN(num)) return 'Please enter a valid number';
+ *     if (num < 0 || num > 120) return 'Age must be between 0 and 120';
+ *     return undefined;
+ *   },
+ * });
+ * ```
+ */

Uh oh!

Conversation

florian-lefebvre commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

Checklist

AI-generated code disclosure

Uh oh!

changeset-bot Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghostdevv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

natemoo-re left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

florian-lefebvre commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

florian-lefebvre commented May 20, 2026

Uh oh!

ghostdevv commented May 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

florian-lefebvre commented May 20, 2026

Uh oh!

florian-lefebvre commented May 20, 2026

Uh oh!

ghostdevv commented May 20, 2026

Uh oh!

florian-lefebvre commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghostdevv commented May 20, 2026

Uh oh!

43081j commented May 21, 2026

Uh oh!

florian-lefebvre commented May 21, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghostdevv left a comment

Choose a reason for hiding this comment

Uh oh!

ghostdevv May 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

florian-lefebvre commented May 19, 2026 •

edited

Loading

changeset-bot Bot commented May 19, 2026 •

edited

Loading

pkg-pr-new Bot commented May 19, 2026 •

edited

Loading

florian-lefebvre commented May 20, 2026 •

edited

Loading

florian-lefebvre commented May 20, 2026 •

edited

Loading